Skip to content

re.Match.lastgroup is str rather than AnyStr#6776

Merged
Akuli merged 1 commit intopython:masterfrom
jpy-git:re_groupindex
Jan 1, 2022
Merged

re.Match.lastgroup is str rather than AnyStr#6776
Akuli merged 1 commit intopython:masterfrom
jpy-git:re_groupindex

Conversation

@jpy-git
Copy link
Contributor

@jpy-git jpy-git commented Jan 1, 2022 •
edited
Loading

Another tweak to re that I spotted when working through the regex stubs.

re.Match.lastgroup is derived from indexgroup (inverse of groupindex) and therefore must be a str:
https://github.com/python/cpython/blob/0b58bac3e7877d722bdbd3c38913dba2cb212f13/Modules/_sre.c#L2375-L2388

Group names are always stored as strings, even if the pattern and string are bytes:

>>> import re
>>> re.compile(b"(?P<letter>\w)").match(b"a1").lastgroup
'letter'

@github-actions
Copy link
Contributor

github-actions bot commented Jan 1, 2022

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@AlexWaygood
Copy link
Member

AlexWaygood commented Jan 1, 2022

Good catch!!

@Akuli Akuli merged commit d43cd99 into python:master Jan 1, 2022
@jpy-git jpy-git deleted the re_groupindex branch January 1, 2022 13:15
@jpy-git jpy-git mentioned this pull request Jan 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Akuli Akuli Akuli approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jpy-git @AlexWaygood @Akuli